![function getItemsWithNext() {
return items
.filter(item => {
if (isDeleted(item)) {
return false
}
return true
})
.map((item, i) => {
const next = items[i + 1]
return {
item,
next,
}
})
}](https://cdn.bsky.app/img/feed_thumbnail/plain/did:plc:p2cp5gopk7mgjegy6wadk3ep/bafkreifjayqiaf2nznful46gpc5kf2y5gjkktlmophvgefr2nvp7uorxtm "function getItemsWithNext() {
return items
.filter(item => {
if (isDeleted(item)) {
return false
}
return true
})
.map((item, i) => {
const next = items[i + 1]
return {
item,
next,
}
})
}")
Samuel
@samuel.fm
what part? we need a function that does 2 things
1. filter out deleted messages
2. provide the next message, for the UI to use
I'm curious what you'd do differently
2 2
Tibor MartiniI guess you could just use a gauge clause inside the map and drop the filter?
1 1Samuelwhat's a gauge clause? 😅
1 1Tibor MartiniSorry, I meant *guard clause 🙈
1 1Samueloh right haha
so what, return null or something and then filter out afterwards?
1Tibor MartiniWould be an option, but wouldn't improve performance.
You could use reduce() instead: stackoverflow.com/questions/24...
Or use a normal loop.
2SamuelPerformance is not an issue here and reduce is wildly more unreadable and bug prone. Avoid reduce where possible imo unless you have a specific need
chelsea bridge> Or use a normal loop.
i was waiting for someone to say that
you don't have a function that needs to do two things, you have two distinct problems to solve and a stack of code that hides bugs and performance issues
1 8SamuelThat is the correct criticism yep. would’ve sidestepped this bug completely
1 2chelsea bridgesometimes i stop shitposting long enough to be coherent
1 4Samuelyou are truly multifaceted :)
1 2chelsea bridgeactually atproto is multifaceted
1
Spoonful of bitterWhy not return each undeleted item with their next companion deleted or not?
The exception raised when the last item is not deleted is a feature, not a bug.
No specs, no bug.