Samuel
@samuel.fm
image lightbox should now open faster on android + has a nice ink ripple effect on press. lmk if you're seeing any improvement
2 15
Tom ShermanI have the ripple but it's still kinda slow 😞 (pixel 9 pro)
1Tom ShermanAh, opening a single image is quite snappy but opening an image from a post with multiple has a bad delay
4 1 5Samuelgood feedback, thanks! hmm, I could maybe defer loading the other images until after it's open
1 4Samuel
Samuelyeah, it's waiting on requestAnimationFrame to fire it seems. maybe I could reduce the amount of work it has to do before the animation fires, it could fire earlier
1 1
Paul RohrSince you've been in the lightbox code recently, could you do a bit of triaging on 7452 to investigate what it'd take to make image rotation on Android less janky?
Rotate images cleanly on mobile · Issue #7452 · bluesky-social/social-app
Steps to Reproduce To feel fully immersive, rotating an image should smoothly toggle only the size + orientation (in a single step). Unlike the simple fix which was landed to close #624, please don...
github.com
Paul RohrThe work you did a year ago on video rotation was buttery-smooth on Android, but I'm assuming getting the lightbox to the same level is non-trivial, or you would've knocked it out already
Paul Rohr@pevohr.bsky.social· 11 Sept 2024Nifty!
The new fullscreen video player does the right when you rotate your mobile device
So once they're done rolling out video upload functionality, maybe that logic can be backported to the image viewer, too 😉
Samuelit’s completely different unfortunately
1Paul RohrYeah, that's what I figured
If you have any quick tips on what'd be needed, might be worth leaving notes in the bug in case anybody else is feeling ambitious
( Last time I peeked under the hood, I got a strong whiff of potential refactoring + retreated )
spooky bubbacan replicate (Samsung s25+)