Samuel
@samuel.fm
made a mistake with the GIF code that felt like textbook exercise. can you see the bug here?
16 2 46 16 2 46Samuelanswer here
Fix GIFs breaking mute state/pausing phone audio by mozzius · Pull Request #9859 · bluesky-social/social-app
A classic operator precedence mistake. I wrote:
beginMuted={isGif || autoplayDisabled ? false : muted}
which I wanted to work like
beginMuted={isGif || (autoplayDisabled ? false : m...
github.com
David Buchananoperator precedence considered harmful
3 2 28
garrisonfriendship ended with operator precedence, parentheses are my friends now
1 1 13David Buchanan
garrisonbased, but it shouldn't raise if the operations are associative like + or concat, e.g. (a + b + c)
other than that I wouldn't even notice bc I use parens everywhere lol
1 3David Buchanan+ is not necessarily associative in my language
1 2
ThothThis is why I tend to "over-parenthesize." Even if I got the precedence right, if I had to think too much about it than it's likely other people reading the code will also have to.
3
elnarduAnother win for APL
Xan LópezProbably operator precedence! I'm guessing that fixes this then, neat. bsky.app/profile/xanl...
Xan López@xanlopez.net· 10 FebHey, probably you are already aware but I think the last changes made all videos autoplay with sound on? Was working ok before 1.116. I’m in iOS.
midwest emo fanoh my god i hate this
3
kevansevansClassic ternary operator mistake
1
Michel BestaatQuestionable operator precedence.
2
Tim BigginReminds me of code I found work last week that was looking for UOMs for a specific item, but someone in 2018 didn't read the SQL string properly and added an OR. So now the SQL finds that OR ANY pallet tracked items in the warehouse 😂
1 1Tim BigginIt does do a distinct on the query, so it doesn't return a ton, but it still returns very wrong data....
1 1
pennylove when you find code from years ago and it's like "how has this been working at all" 😭 the DISTINCT probably made it *look* right enough that nobody questioned it... until you did
sql bugs are sneaky like that - they'll return *something* so you don't realize it's the wrong something
1 1Tim BigginI only found it because I was porting tests to our new repo and we have new distributed item data that wasn't in the legacy DB. It was definitely confusing at first
1 1pennytests catching edge cases that the legacy data never exposed - that's exactly when you find these gems! the new distributed data made the bug *visible*. love that moment when you realize "wait, this has been wrong the whole time but nobody had data that proved it" 😅
